Commit 164165da authored by Joe Perches's avatar Joe Perches Committed by David S. Miller
Browse files

drivers/net: tasklet_init - Remove unnecessary leading & from second arg 



Changed function pointer use from non-majority address-of style
to majority short form without & via: (was: 8 with &, 36 without)

grep -rPl "\btasklet_init\s*\([^,\)]+,\s*\&" drivers/net | while read file ; do \
	perl -i -e 'local $/; while (<>) { s@(\btasklet_init\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
done

Compile tested allyesconfig x86

Signed-off-by: default avatarJoe Perches <joe@perches.com>

 drivers/net/cnic.c |    4 ++--
 drivers/net/jme.c  |   10 +++++-----
 drivers/net/skge.c |    2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5452fee2

drivers/net/cnic.c

+2 −2
Original line number Diff line number Diff line
@@ -3387,7 +3387,7 @@ static int cnic_init_bnx2_irq(struct cnic_dev *dev) 


		cp->bnx2_status_blk = cp->status_blk;

		cp->last_status_idx = cp->bnx2_status_blk->status_idx;

		tasklet_init(&cp->cnic_irq_task, &cnic_service_bnx2_msix,

		tasklet_init(&cp->cnic_irq_task, cnic_service_bnx2_msix,

			     (unsigned long) dev);

		err = request_irq(ethdev->irq_arr[0].vector, cnic_irq, 0,

				  "cnic", dev);
@@ -3787,7 +3787,7 @@ static int cnic_init_bnx2x_irq(struct cnic_dev *dev) 
	struct cnic_eth_dev *ethdev = cp->ethdev;

	int err = 0;



	tasklet_init(&cp->cnic_irq_task, &cnic_service_bnx2x_bh,

	tasklet_init(&cp->cnic_irq_task, cnic_service_bnx2x_bh,

		     (unsigned long) dev);

	if (ethdev->drv_state & CNIC_DRV_STATE_USING_MSIX) {

		err = request_irq(ethdev->irq_arr[0].vector, cnic_irq, 0,

drivers/net/jme.c

+5 −5
Original line number Diff line number Diff line
@@ -2764,19 +2764,19 @@ jme_init_one(struct pci_dev *pdev, 
	atomic_set(&jme->rx_empty, 1);



	tasklet_init(&jme->pcc_task,

		     &jme_pcc_tasklet,

		     jme_pcc_tasklet,

		     (unsigned long) jme);

	tasklet_init(&jme->linkch_task,

		     &jme_link_change_tasklet,

		     jme_link_change_tasklet,

		     (unsigned long) jme);

	tasklet_init(&jme->txclean_task,

		     &jme_tx_clean_tasklet,

		     jme_tx_clean_tasklet,

		     (unsigned long) jme);

	tasklet_init(&jme->rxclean_task,

		     &jme_rx_clean_tasklet,

		     jme_rx_clean_tasklet,

		     (unsigned long) jme);

	tasklet_init(&jme->rxempty_task,

		     &jme_rx_empty_tasklet,

		     jme_rx_empty_tasklet,

		     (unsigned long) jme);

	tasklet_disable_nosync(&jme->linkch_task);

	tasklet_disable_nosync(&jme->txclean_task);

drivers/net/skge.c

+1 −1
Original line number Diff line number Diff line
@@ -3947,7 +3947,7 @@ static int __devinit skge_probe(struct pci_dev *pdev, 
	hw->pdev = pdev;

	spin_lock_init(&hw->hw_lock);

	spin_lock_init(&hw->phy_lock);

	tasklet_init(&hw->phy_task, &skge_extirq, (unsigned long) hw);

	tasklet_init(&hw->phy_task, skge_extirq, (unsigned long) hw);



	hw->regs = ioremap_nocache(pci_resource_start(pdev, 0), 0x4000);

	if (!hw->regs) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE