Commit 163ae1c6 authored Sep 08, 2016 by Eric Biggers Committed by Theodore Ts'o Sep 09, 2016

fscrypto: add authorization check for setting encryption policy



On an ext4 or f2fs filesystem with file encryption supported, a user
could set an encryption policy on any empty directory(*) to which they
had readonly access.  This is obviously problematic, since such a
directory might be owned by another user and the new encryption policy
would prevent that other user from creating files in their own directory
(for example).

Fix this by requiring inode_owner_or_capable() permission to set an
encryption policy.  This means that either the caller must own the file,
or the caller must have the capability CAP_FOWNER.

(*) Or also on any regular file, for f2fs v4.6 and later and ext4
    v4.8-rc1 and later; a separate bug fix is coming for that.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Cc: stable@vger.kernel.org # 4.1+; check fs/{ext4,f2fs}
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent c6935931

fs/crypto/policy.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -95,6 +95,9 @@ static int create_encryption_context_from_policy(struct inode *inode,
		int fscrypt_process_policy(struct inode *inode,
		const struct fscrypt_policy *policy)
		{
		if (!inode_owner_or_capable(inode))
		return -EACCES;

		if (policy->version != 0)
		return -EINVAL;

Admin message