Commit 1630146d authored Jan 27, 2020 by Geert Uytterhoeven Committed by Jonathan Corbet Jan 27, 2020

scripts/find-unused-docs: Fix massive false positives



scripts/find-unused-docs.sh invokes scripts/kernel-doc to find out if a
source file contains kerneldoc or not.

However, as it passes the no longer supported "-text" option to
scripts/kernel-doc, the latter prints out its help text, causing all
files to be considered containing kerneldoc.

Get rid of these false positives by removing the no longer supported
"-text" option from the scripts/kernel-doc invocation.

Cc: stable@vger.kernel.org  # 4.16+
Fixes: b0514267 ("scripts: kernel-doc: get rid of unused output formats")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20200127093107.26401-1-geert+renesas@glider.be


Signed-off-by: Jonathan Corbet <corbet@lwn.net>

parent 06b9c269

scripts/find-unused-docs.sh

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -54,7 +54,7 @@ for file in `find $1 -name '*.c'`; do
	if [[ ${FILES_INCLUDED[$file]+_} ]]; then		if [[ ${FILES_INCLUDED[$file]+_} ]]; then
	continue;		continue;
	fi		fi
	str=$(scripts/kernel-doc -text -export "$file" 2>/dev/null)		str=$(scripts/kernel-doc -export "$file" 2>/dev/null)
	if [[ -n "$str" ]]; then		if [[ -n "$str" ]]; then
	echo "$file"		echo "$file"
	fi		fi

Admin message