imx-drm: imx-tve: Let device core handle pinctrl (15f29f7f) · Commits · 戴 / test

Since commit (drivers/pinctrl: grab default handles from device core) we can rely on device core for handling pinctrl, so remove devm_pinctrl_get_select_default() from the driver. Signed-off-by:

Fabio Estevam <fabio.estevam@freescale.com> Acked-by:

Shawn Guo <shawn.guo@linaro.org> Acked-by:

Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/imx-drm/imx-tve.c

+0 −10

Original line number	Diff line number	Diff line
		@@ -22,7 +22,6 @@
		#include <linux/clk-provider.h>
		#include <linux/module.h>
		#include <linux/of_i2c.h>
		#include <linux/pinctrl/consumer.h>
		#include <linux/regmap.h>
		#include <linux/regulator/consumer.h>
		#include <linux/spinlock.h>
		@@ -610,15 +609,6 @@ static int imx_tve_probe(struct platform_device *pdev)
		}

		if (tve->mode == TVE_MODE_VGA) {
		struct pinctrl *pinctrl;

		pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
		if (IS_ERR(pinctrl)) {
		ret = PTR_ERR(pinctrl);
		dev_warn(&pdev->dev, "failed to setup pinctrl: %d", ret);
		return ret;
		}

		ret = of_property_read_u32(np, "fsl,hsync-pin", &tve->hsync_pin);
		if (ret < 0) {
		dev_err(&pdev->dev, "failed to get vsync pin\n");

Admin message