Commit 15ee2992 authored Oct 15, 2018 by Gustavo A. R. Silva Committed by Dmitry Torokhov Oct 15, 2018

Input: cyapa - mark expected switch fall-throughs



In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case, I replaced the "Fallthrough state"
commern with a proper "Fall through", which is what GCC is expecting to
find.

Addresses-Coverity-ID: 114758 ("Missing break in switch")
Addresses-Coverity-ID: 114759 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent a3f7c3fc

drivers/input/mouse/cyapa_gen3.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1067,7 +1067,7 @@ static int cyapa_gen3_do_operational_check(struct cyapa *cyapa)
		return error;
		}

		/* Fallthrough state */
		/* Fall through */
		case CYAPA_STATE_BL_IDLE:
		/* Try to get firmware version in bootloader mode. */
		cyapa_gen3_bl_query_data(cyapa);
		@@ -1078,7 +1078,7 @@ static int cyapa_gen3_do_operational_check(struct cyapa *cyapa)
		return error;
		}

		/* Fallthrough state */
		/* Fall through */
		case CYAPA_STATE_OP:
		/*
		* Reading query data before going back to the full mode

Admin message