Commit 15ddb4ae authored May 14, 2010 by Pavel Emelyanov Committed by J. Bruce Fields May 14, 2010

NFSD: don't report compiled-out versions as present



The /proc/fs/nfsd/versions file calls nfsd_vers() to check whether
the particular nfsd version is present/available. The problem is
that once I turn off e.g. NFSD-V4 this call returns -1 which is
true from the callers POV which is wrong.

The proposal is to report false in that case.

The bug has existed since 6658d3a7 "[PATCH] knfsd: remove
nfsd_versbits as intermediate storage for desired versions".

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: stable@kernel.org
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

parent 4dc6ec00

fs/nfsd/nfssvc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -120,7 +120,7 @@ u32 nfsd_supported_minorversion;
		int nfsd_vers(int vers, enum vers_op change)
		{
		if (vers < NFSD_MINVERS \|\| vers >= NFSD_NRVERS)
		return -1;
		return 0;
		switch(change) {
		case NFSD_SET:
		nfsd_versions[vers] = nfsd_version[vers];

Admin message