Commit 15da4b16 authored Jul 01, 2009 by Abhishek Kulkarni Committed by David S. Miller Jul 02, 2009

net/9p: Fix crash due to bad mount parameters.



It is not safe to use match_int without checking the token type returned
by match_token (especially when the token type returned is Opt_err and
args is empty). Fix it.

Signed-off-by: Abhishek Kulkarni <adkulkar@umail.iu.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 887b5ea3

net/9p/trans_fd.c

+8 −6

Original line number	Diff line number	Diff line
		@@ -735,6 +735,7 @@ static int parse_opts(char params, struct p9_fd_opts opts)
		if (!*p)
		continue;
		token = match_token(p, tokens, args);
		if (token != Opt_err) {
		r = match_int(&args[0], &option);
		if (r < 0) {
		P9_DPRINTK(P9_DEBUG_ERROR,
		@@ -742,6 +743,7 @@ static int parse_opts(char params, struct p9_fd_opts opts)
		ret = r;
		continue;
		}
		}
		switch (token) {
		case Opt_port:
		opts->port = option;

Admin message