Commit 15d0d3b3 authored Feb 25, 2009 by Nick Piggin Committed by Ingo Molnar Feb 25, 2009

generic IPI: simplify barriers and locking



Simplify the barriers in generic remote function call interrupt
code.

Firstly, just unconditionally take the lock and check the list
in the generic_call_function_single_interrupt IPI handler. As
we've just taken an IPI here, the chances are fairly high that
there will be work on the list for us, so do the locking
unconditionally. This removes the tricky lockless list_empty
check and dubious barriers. The change looks bigger than it is
because it is just removing an outer loop.

Secondly, clarify architecture specific IPI locking rules.
Generic code has no tools to impose any sane ordering on IPIs if
they go outside normal cache coherency, ergo the arch code must
make them appear to obey cache coherency as a "memory operation"
to initiate an IPI, and a "memory operation" to receive one.
This way at least they can be reasoned about in generic code,
and smp_mb used to provide ordering.

The combination of these two changes means that explict barriers
can be taken out of queue handling for the single case -- shared
data is explicitly locked, and ipi ordering must conform to
that, so no barriers needed. An extra barrier is needed in the
many handler, so as to ensure we load the list element after the
IPI is received.

Does any architecture actually *need* these barriers? For the
initiator I could see it, but for the handler I would be
surprised. So the other thing we could do for simplicity is just
to require that, rather than just matching with cache coherency,
we just require a full barrier before generating an IPI, and
after receiving an IPI. In which case, the smp_mb()s can go
away. But just for now, we'll be on the safe side and use the
barriers (they're in the slow case anyway).

Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-arch@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent f7e603ad

kernel/smp.c

+44 −39

Original line number	Diff line number	Diff line
		@@ -74,9 +74,16 @@ static void generic_exec_single(int cpu, struct call_single_data *data)
		spin_unlock_irqrestore(&dst->lock, flags);

		/*
		* Make the list addition visible before sending the ipi.
		* The list addition should be visible before sending the IPI
		* handler locks the list to pull the entry off it because of
		* normal cache coherency rules implied by spinlocks.
		*
		* If IPIs can go out of order to the cache coherency protocol
		* in an architecture, sufficient synchronisation should be added
		* to arch code to make it appear to obey cache coherency WRT
		* locking and barrier primitives. Generic code isn't really equipped
		* to do the right thing...
		*/
		smp_mb();

		if (ipi)
		arch_send_call_function_single_ipi(cpu);
		@@ -103,6 +110,14 @@ void generic_smp_call_function_interrupt(void)
		struct call_function_data *data;
		int cpu = get_cpu();

		/*
		* Ensure entry is visible on call_function_queue after we have
		* entered the IPI. See comment in smp_call_function_many.
		* If we don't have this, then we may miss an entry on the list
		* and never get another IPI to process it.
		*/
		smp_mb();

		/*
		* It's ok to use list_for_each_rcu() here even though we may delete
		* 'pos', since list_del_rcu() doesn't clear ->next
		@@ -154,13 +169,6 @@ void generic_smp_call_function_single_interrupt(void)
		{
		struct call_single_queue *q = &__get_cpu_var(call_single_queue);
		LIST_HEAD(list);

		/*
		* Need to see other stores to list head for checking whether
		* list is empty without holding q->lock
		*/
		smp_read_barrier_depends();
		while (!list_empty(&q->list)) {
		unsigned int data_flags;

		spin_lock(&q->lock);
		@@ -193,11 +201,6 @@ void generic_smp_call_function_single_interrupt(void)
		} else if (data_flags & CSD_FLAG_ALLOC)
		kfree(data);
		}
		/*
		* See comment on outer loop
		*/
		smp_read_barrier_depends();
		}
		}

		static DEFINE_PER_CPU(struct call_single_data, csd_data);
		@@ -375,6 +378,8 @@ void smp_call_function_many(const struct cpumask *mask,

		/*
		* Make the list addition visible before sending the ipi.
		* (IPIs must obey or appear to obey normal Linux cache coherency
		* rules -- see comment in generic_exec_single).
		*/
		smp_mb();

Admin message