Commit 15bc8d84 authored Jan 25, 2013 by Christian Borntraeger Committed by Gleb Natapov Jan 30, 2013

s390/kvm: Fix store status for ACRS/FPRS



On store status we need to copy the current state of registers
into a save area. Currently we might save stale versions:
The sie state descriptor doesnt have fields for guest ACRS,FPRS,
those registers are simply stored in the host registers. The host
program must copy these away if needed. We do that in vcpu_put/load.

If we now do a store status in KVM code between vcpu_put/load, the
saved values are not up-to-date. Lets collect the ACRS/FPRS before
saving them.

This also fixes some strange problems with hotplug and virtio-ccw,
since the low level machine check handler (on hotplug a machine check
will happen) will revalidate all registers with the content of the
save area.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
CC: stable@vger.kernel.org
Signed-off-by: Gleb Natapov <gleb@redhat.com>

parent c45c528e

arch/s390/kvm/kvm-s390.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -770,6 +770,14 @@ int kvm_s390_vcpu_store_status(struct kvm_vcpu *vcpu, unsigned long addr)
		} else
		prefix = 0;

		/*
		* The guest FPRS and ACRS are in the host FPRS/ACRS due to the lazy
		* copying in vcpu load/put. Lets update our copies before we save
		* it into the save area
		*/
		save_fp_regs(&vcpu->arch.guest_fpregs);
		save_access_regs(vcpu->run->s.regs.acrs);

		if (__guestcopy(vcpu, addr + offsetof(struct save_area, fp_regs),
		vcpu->arch.guest_fpregs.fprs, 128, prefix))
		return -EFAULT;

Admin message