Commit 15badbcc authored by Dan Williams's avatar Dan Williams Committed by Greg Kroah-Hartman
Browse files

option: add Alcatel X200 to sendsetup blacklist 



This modem really wants sendsetup blacklisted for interfaces 0 and 1,
otherwise the kernel hardlocks for about 10 seconds while waiting for
the modem's firmware to respond, which it of course doesn't do.

A slight complication here is that TCT (who owns the Alcatel brand) used
the same USB IDs for the X200 as the X060s despite the devices having
completely different firmware and AT command sets, so we end up adding
the X060s to the blacklist at the same time.  PSA to OEMs: don't use the
same USB IDs for different devices.  Really.  It makes your kittens cry.

Signed-off-by: default avatarDan Williams <dcbw@redhat.com>
Cc: stable@kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent cdacb598

drivers/usb/serial/option.c

+11 −2
Original line number Diff line number Diff line
@@ -344,7 +344,7 @@ static void option_instat_callback(struct urb *urb); 


/* ALCATEL PRODUCTS */

#define ALCATEL_VENDOR_ID			0x1bbb

#define ALCATEL_PRODUCT_X060S			0x0000

#define ALCATEL_PRODUCT_X060S_X200		0x0000



#define PIRELLI_VENDOR_ID			0x1266

#define PIRELLI_PRODUCT_C100_1			0x1002
@@ -435,6 +435,13 @@ static const struct option_blacklist_info four_g_w14_blacklist = { 
	.reason = OPTION_BLACKLIST_SENDSETUP

};



static const u8 alcatel_x200_no_sendsetup[] = { 0, 1 };

static const struct option_blacklist_info alcatel_x200_blacklist = {

	.infolen = ARRAY_SIZE(alcatel_x200_no_sendsetup),

	.ifaceinfo = alcatel_x200_no_sendsetup,

	.reason = OPTION_BLACKLIST_SENDSETUP

};



static const struct usb_device_id option_ids[] = {

	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) },

	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) },
@@ -939,7 +946,9 @@ static const struct usb_device_id option_ids[] = { 
	{ USB_DEVICE(TOSHIBA_VENDOR_ID, TOSHIBA_PRODUCT_HSDPA_MINICARD ) }, /* Toshiba 3G HSDPA == Novatel Expedite EU870D MiniCard */

	{ USB_DEVICE(ALINK_VENDOR_ID, 0x9000) },

	{ USB_DEVICE_AND_INTERFACE_INFO(ALINK_VENDOR_ID, ALINK_PRODUCT_3GU, 0xff, 0xff, 0xff) },

	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_X060S) },

	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_X060S_X200),

	  .driver_info = (kernel_ulong_t)&alcatel_x200_blacklist

	},

	{ USB_DEVICE(AIRPLUS_VENDOR_ID, AIRPLUS_PRODUCT_MCD650) },

	{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },

	{ USB_DEVICE(LONGCHEER_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),

CRA Git | Maintained and supported by SUSTech CRA and CCSE