Commit 15af974d authored May 07, 2010 by Vasu Dev Committed by James Bottomley May 16, 2010

[SCSI] fcoe: fix fcoe module ref counting



Currently fcoe module ref count is used for tracking
active fcoe instances, it means each fcoe instance create
increments the count while destroy dec the count.

The dec is done only if fcoe instance is destroyed from
/sysfs but not if destroyed due to NETDEV_UNREGISTER event.
So this patch moves only module_put doing dec to common
fcoe_if_destroy function, so that dec would occur on ever
fcoe instance destroy.

Signed-off-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent fb83153d

drivers/scsi/fcoe/fcoe.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -851,6 +851,7 @@ static void fcoe_if_destroy(struct fc_lport *lport)

		/* Release the Scsi_Host */
		scsi_host_put(lport->host);
		module_put(THIS_MODULE);
		}

		/**
		@@ -2034,7 +2035,6 @@ static int fcoe_destroy(const char buffer, struct kernel_param kp)
		fcoe_interface_cleanup(fcoe);
		/* RTNL mutex is dropped by fcoe_if_destroy */
		fcoe_if_destroy(fcoe->ctlr.lp);
		module_put(THIS_MODULE);

		out_putdev:
		dev_put(netdev);

Admin message