Commit 15a2d4de authored May 05, 2014 by Peter Zijlstra Committed by Ingo Molnar May 07, 2014

perf: Always destroy groups on exit



Commit 38b435b1 ("perf: Fix tear-down of inherited group events")
states that we need to destroy groups for inherited events, but it
doesn't make any sense to not also destroy groups for normal events.

And while it usually makes no difference (the normal events won't
leak, and its very likely all the group events will die in quick
succession) it does make the code more consistent and closes a
potential hole for trouble.

Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-426egt8zmsm12d2q8k2xz4tt@git.kernel.org


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 1f4ee503

kernel/events/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -7400,7 +7400,7 @@ __perf_event_exit_task(struct perf_event *child_event,
		struct perf_event_context *child_ctx,
		struct task_struct *child)
		{
		perf_remove_from_context(child_event, !!child_event->parent);
		perf_remove_from_context(child_event, true);

		/*
		* It can happen that the parent exits first, and has events

Admin message