Commit 15999eef authored Aug 06, 2020 by Roman Gushchin Committed by Linus Torvalds Aug 07, 2020

mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo()



memcg_accumulate_slabinfo() is never called with a non-root kmem_cache as
a first argument, so the is_root_cache(s) check is redundant and can be
removed without any functional change.

Signed-off-by: Roman Gushchin <guro@fb.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Link: http://lkml.kernel.org/r/20200623174037.3951353-17-guro@fb.com


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent c7094406

mm/slab_common.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1104,9 +1104,6 @@ memcg_accumulate_slabinfo(struct kmem_cache s, struct slabinfo info)
		struct kmem_cache *c;
		struct slabinfo sinfo;

		if (!is_root_cache(s))
		return;

		c = memcg_cache(s);
		if (c) {
		memset(&sinfo, 0, sizeof(sinfo));

Admin message