Commit 1592cd15 authored May 20, 2020 by Chaitanya Kulkarni Committed by Jens Axboe May 21, 2020

null_blk: don't allow discard for zoned mode



Zoned block device specification do not define the behavior of
discard/trim command as this command is generally replaced by the reset
write pointer (zone reset) command. Emulate this in null_blk by making
zoned and discard options mutually exclusive.

Suggested-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent e2748325

drivers/block/null_blk_main.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -1535,6 +1535,13 @@ static void null_config_discard(struct nullb *nullb)
		{
		if (nullb->dev->discard == false)
		return;

		if (nullb->dev->zoned) {
		nullb->dev->discard = false;
		pr_info("discard option is ignored in zoned mode\n");
		return;
		}

		nullb->q->limits.discard_granularity = nullb->dev->blocksize;
		nullb->q->limits.discard_alignment = nullb->dev->blocksize;
		blk_queue_max_discard_sectors(nullb->q, UINT_MAX >> 9);

Admin message