Commit 157b9ce7 authored by Jeykumar Sankaran's avatar Jeykumar Sankaran Committed by Rob Clark
Browse files

drm/msm/dpu: relax parameter validation in encoders 



DPU, being over protective, validates every parameter of a
module. This change traces the call stack for some of encoder
functions affected by previous set of clean up patches and
cleans up unwanted validations.

changes in v5:
	- Introduced in the series
changes in v6:
	- none

Signed-off-by: default avatarJeykumar Sankaran <jsanka@codeaurora.org>
Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarSean Paul <seanpaul@chromium.org>
Signed-off-by: default avatarRob Clark <robdclark@gmail.com>
parent 32ecf92a

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

+0 −6
Original line number Diff line number Diff line
@@ -441,12 +441,6 @@ void dpu_encoder_get_hw_resources(struct drm_encoder *drm_enc, 
	struct dpu_encoder_virt *dpu_enc = NULL;

	int i = 0;



	if (!hw_res || !drm_enc) {

		DPU_ERROR("invalid argument(s), drm_enc %d, res %d\n",

			  drm_enc != 0, hw_res != 0);

		return;

	}



	dpu_enc = to_dpu_encoder_virt(drm_enc);

	DPU_DEBUG_ENC(dpu_enc, "\n");

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c

+0 −14
Original line number Diff line number Diff line
@@ -601,20 +601,6 @@ static void dpu_encoder_phys_cmd_get_hw_resources( 
		struct dpu_encoder_phys *phys_enc,

		struct dpu_encoder_hw_resources *hw_res)

{

	struct dpu_encoder_phys_cmd *cmd_enc =

		to_dpu_encoder_phys_cmd(phys_enc);



	if (!phys_enc) {

		DPU_ERROR("invalid encoder\n");

		return;

	}



	if ((phys_enc->intf_idx - INTF_0) >= INTF_MAX) {

		DPU_ERROR("invalid intf idx:%d\n", phys_enc->intf_idx);

		return;

	}



	DPU_DEBUG_CMDENC(cmd_enc, "\n");

	hw_res->intfs[phys_enc->intf_idx - INTF_0] = INTF_MODE_CMD;

}

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c

+0 −6
Original line number Diff line number Diff line
@@ -539,12 +539,6 @@ static void dpu_encoder_phys_vid_get_hw_resources( 
		struct dpu_encoder_phys *phys_enc,

		struct dpu_encoder_hw_resources *hw_res)

{

	if (!phys_enc || !hw_res) {

		DPU_ERROR("invalid arg(s), enc %d hw_res %d\n",

			  phys_enc != 0, hw_res != 0);

		return;

	}



	hw_res->intfs[phys_enc->intf_idx - INTF_0] = INTF_MODE_VIDEO;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE