Commit 1574dff8 authored Apr 20, 2011 by Sachin Prabhu Committed by J. Bruce Fields Apr 20, 2011

Open with O_CREAT flag set fails to open existing files on non writable directories



An open on a NFS4 share using the O_CREAT flag on an existing file for
which we have permissions to open but contained in a directory with no
write permissions will fail with EACCES.

A tcpdump shows that the client had set the open mode to UNCHECKED which
indicates that the file should be created if it doesn't exist and
encountering an existing flag is not an error. Since in this case the
file exists and can be opened by the user, the NFS server is wrong in
attempting to check create permissions on the parent directory.

The patch adds a conditional statement to check for create permissions
only if the file doesn't exist.

Signed-off-by: Sachin S. Prabhu <sprabhu@redhat.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent a96e5b90

fs/nfsd/vfs.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -1363,7 +1363,7 @@ nfsd_create_v3(struct svc_rqst rqstp, struct svc_fh fhp,
		goto out;
		if (!(iap->ia_valid & ATTR_MODE))
		iap->ia_mode = 0;
		err = fh_verify(rqstp, fhp, S_IFDIR, NFSD_MAY_CREATE);
		err = fh_verify(rqstp, fhp, S_IFDIR, NFSD_MAY_EXEC);
		if (err)
		goto out;

		@@ -1385,6 +1385,13 @@ nfsd_create_v3(struct svc_rqst rqstp, struct svc_fh fhp,
		if (IS_ERR(dchild))
		goto out_nfserr;

		/* If file doesn't exist, check for permissions to create one */
		if (!dchild->d_inode) {
		err = fh_verify(rqstp, fhp, S_IFDIR, NFSD_MAY_CREATE);
		if (err)
		goto out;
		}

		err = fh_compose(resfhp, fhp->fh_export, dchild, fhp);
		if (err)
		goto out;

Admin message