Commit 15529456 authored Jul 30, 2007 by Tejun Heo Committed by Jeff Garzik Oct 12, 2007

libata: use ata_port_printk() in ata_wait_idle()



ata_wait_idle() identified controller by printing out the address of
the Status register.  This is bogus because 1. it's iomapped address
2. some controllers don't have Status register and don't initialize
the field.  Use ata_port_printk() instead.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent b8773531

include/linux/libata.h

+4 −2

Original line number	Diff line number	Diff line
		@@ -1182,9 +1182,11 @@ static inline u8 ata_wait_idle(struct ata_port *ap)
		{
		u8 status = ata_busy_wait(ap, ATA_BUSY \| ATA_DRQ, 1000);

		#ifdef ATA_DEBUG
		if (status != 0xff && (status & (ATA_BUSY \| ATA_DRQ)))
		DPRINTK("ATA: abnormal status 0x%X on port 0x%p\n",
		status, ap->ioaddr.status_addr);
		ata_port_printk(ap, KERN_DEBUG, "abnormal Status 0x%X\n",
		status);
		#endif

		return status;
		}

Admin message