net/mlx5e: Properly initialize flow attributes for slow path eswitch rule deletion (154e62ab) · Commits · 戴 / test

When a neighbour is resolved, we delete the goto slow path rule from HW. The eswitch flow attributes where not properly initialized on that case, hence we mess up the eswitch refcounts for chain zero (the default one). Fix that along with making sure to use semicolons and not commas on that code; Fixes: ('net/mlx5e: Use a slow path rule instead if vxlan neighbour isn't available') Signed-off-by:

Or Gerlitz <ogerlitz@mellanox.com> Reviewed-by:

Paul Blakey <paulb@mellanox.com> Signed-off-by:

Saeed Mahameed <saeedm@mellanox.com>

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -870,9 +870,9 @@ mlx5e_tc_offload_to_slow_path(struct mlx5_eswitch *esw,
		struct mlx5_flow_handle *rule;

		memcpy(slow_attr, flow->esw_attr, sizeof(*slow_attr));
		slow_attr->action = MLX5_FLOW_CONTEXT_ACTION_FWD_DEST,
		slow_attr->mirror_count = 0,
		slow_attr->dest_chain = FDB_SLOW_PATH_CHAIN,
		slow_attr->action = MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
		slow_attr->mirror_count = 0;
		slow_attr->dest_chain = FDB_SLOW_PATH_CHAIN;

		rule = mlx5e_tc_offload_fdb_rules(esw, flow, spec, slow_attr);
		if (!IS_ERR(rule))
		@@ -887,6 +887,9 @@ mlx5e_tc_unoffload_from_slow_path(struct mlx5_eswitch *esw,
		struct mlx5_esw_flow_attr *slow_attr)
		{
		memcpy(slow_attr, flow->esw_attr, sizeof(*slow_attr));
		slow_attr->action = MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
		slow_attr->mirror_count = 0;
		slow_attr->dest_chain = FDB_SLOW_PATH_CHAIN;
		mlx5e_tc_unoffload_fdb_rules(esw, flow, slow_attr);
		flow->flags &= ~MLX5E_TC_FLOW_SLOW;
		}

Admin message