Commit 15460de7 authored Mar 17, 2013 by Grazvydas Ignotas Committed by Felipe Balbi Mar 21, 2013

usb: phy: twl4030-usb: don't switch the phy on/off needlessly



With runtime_pm in place there is no longer need to turn the phy
on/off in OTG layer on cable connect/disconnect, OMAP glue does
this through otg.set_suspend() callback after it's called through
omap_musb_mailbox() on VBUS/ID interrupt. Not doing this will save
power when cable is connected but no gadget driver is loaded.

This will also have side effect of automatic USB charging no longer
working without twl4030_charger driver, because a regulator needed
for charging will no longer be enabled, so be sure to enable charger
driver if charging is needed.

Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent ca4f70ce

drivers/usb/phy/phy-twl4030-usb.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -498,12 +498,6 @@ static irqreturn_t twl4030_usb_irq(int irq, void *_twl)
		* USB_LINK_VBUS state. musb_hdrc won't care until it
		* starts to handle softconnect right.
		*/
		if (status == OMAP_MUSB_VBUS_OFF \|\|
		status == OMAP_MUSB_ID_FLOAT)
		twl4030_phy_suspend(twl, 0);
		else
		twl4030_phy_resume(twl);

		omap_musb_mailbox(twl->linkstat);
		}
		sysfs_notify(&twl->dev->kobj, NULL, "vbus");

Admin message