scsi: lpfc: Fix update of wq consumer index in lpfc_sli4_wq_release (1543af38) · Commits · 戴 / test

The lpfc_sli4_wq_release() routine iterates for each interim value when updating the wq consuemr index. This wastes cycles and possibly confuses things as thevalue itterates (and the modulo logic is being applied). There's no reason for this. Just set it to the value from the hw. Link: https://lore.kernel.org/r/20200322181304.37655-7-jsmart2021@gmail.com Signed-off-by:

James Smart <jsmart2021@gmail.com> Signed-off-by:

Dick Kennedy <dick.kennedy@broadcom.com> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/lpfc/lpfc_sli.c

+4 −13

Original line number	Diff line number	Diff line
		@@ -230,25 +230,16 @@ lpfc_sli4_wq_put(struct lpfc_queue q, union lpfc_wqe128 wqe)
		* This routine will update the HBA index of a queue to reflect consumption of
		* Work Queue Entries by the HBA. When the HBA indicates that it has consumed
		* an entry the host calls this function to update the queue's internal
		* pointers. This routine returns the number of entries that were consumed by
		* the HBA.
		* pointers.
		**/
		static uint32_t
		static void
		lpfc_sli4_wq_release(struct lpfc_queue *q, uint32_t index)
		{
		uint32_t released = 0;

		/* sanity check on queue memory */
		if (unlikely(!q))
		return 0;
		return;

		if (q->hba_index == index)
		return 0;
		do {
		q->hba_index = ((q->hba_index + 1) % q->entry_count);
		released++;
		} while (q->hba_index != index);
		return released;
		q->hba_index = index;
		}

		/**

Admin message