Commit 151fc5df authored Nov 20, 2007 by Julia Lawall Committed by Greg Kroah-Hartman Nov 28, 2007

PCI: drivers/pci/pci-sysfs.c: Add missing pci_dev_put



There should be a pci_dev_put when breaking out of a loop that iterates
over calls to pci_get_device and similar functions.

This was fixed using the following semantic patch.

// <smpl>
@@
identifier d;
type T;
expression e;
iterator for_each_pci_dev;
@@

T *d;
...
for_each_pci_dev(d)
  {... when != pci_dev_put(d)
       when != e = d
(
   return d;
|
+  pci_dev_put(d);
?  return ...;
)
...}
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent bf164410

drivers/pci/pci-sysfs.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -702,9 +702,11 @@ static int __init pci_sysfs_init(void)
		sysfs_initialized = 1;
		for_each_pci_dev(pdev) {
		retval = pci_create_sysfs_dev_files(pdev);
		if (retval)
		if (retval) {
		pci_dev_put(pdev);
		return retval;
		}
		}

		return 0;
		}

Admin message