Commit 151ea094 authored by Prashant Malani's avatar Prashant Malani Committed by David S. Miller
Browse files

r8152: Add identifier names for function pointers 



Checkpatch throws warnings for function pointer declarations which lack
identifier names.

An example of such a warning is:

WARNING: function definition argument 'struct r8152 *' should
also have an identifier name
739: FILE: drivers/net/usb/r8152.c:739:
+               void (*init)(struct r8152 *);

So, fix those warnings by adding the identifier names.

While we are at it, also fix a character limit violation which was
causing another checkpatch warning.

Change-Id: Idec857ce2dc9592caf3173188be1660052c052ce
Signed-off-by: default avatarPrashant Malani <pmalani@chromium.org>
Reviewed-by: default avatarGrant Grundler <grundler@chromium.org>
Acked-by: default avatarHayes Wang <hayeswang@realtek.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fab401e1

drivers/net/usb/r8152.c

+12 −11
Original line number Diff line number Diff line
@@ -736,16 +736,16 @@ struct r8152 { 
	struct tasklet_struct tx_tl;



	struct rtl_ops {

		void (*init)(struct r8152 *);

		int (*enable)(struct r8152 *);

		void (*disable)(struct r8152 *);

		void (*up)(struct r8152 *);

		void (*down)(struct r8152 *);

		void (*unload)(struct r8152 *);

		int (*eee_get)(struct r8152 *, struct ethtool_eee *);

		int (*eee_set)(struct r8152 *, struct ethtool_eee *);

		bool (*in_nway)(struct r8152 *);

		void (*hw_phy_cfg)(struct r8152 *);

		void (*init)(struct r8152 *tp);

		int (*enable)(struct r8152 *tp);

		void (*disable)(struct r8152 *tp);

		void (*up)(struct r8152 *tp);

		void (*down)(struct r8152 *tp);

		void (*unload)(struct r8152 *tp);

		int (*eee_get)(struct r8152 *tp, struct ethtool_eee *eee);

		int (*eee_set)(struct r8152 *tp, struct ethtool_eee *eee);

		bool (*in_nway)(struct r8152 *tp);

		void (*hw_phy_cfg)(struct r8152 *tp);

		void (*autosuspend_en)(struct r8152 *tp, bool enable);

	} rtl_ops;
@@ -5603,7 +5603,8 @@ static int rtl8152_probe(struct usb_interface *intf, 
	}



	if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 && udev->serial &&

	    (!strcmp(udev->serial, "000001000000") || !strcmp(udev->serial, "000002000000"))) {

	    (!strcmp(udev->serial, "000001000000") ||

	     !strcmp(udev->serial, "000002000000"))) {

		dev_info(&udev->dev, "Dell TB16 Dock, disable RX aggregation");

		set_bit(DELL_TB_RX_AGG_BUG, &tp->flags);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE