Commit 14f2ae83 authored Jan 22, 2015 by Emmanuel Grumbach Committed by Johannes Berg Jan 23, 2015

mac80211: synchronize_net() before flushing the queues



When mac80211 disconnects, it drops all the packets on the
queues. This happens after the net stack has been notified
that we have no link anymore (netif_carrier_off).
netif_carrier_off ensures that no new packets are sent to
xmit() callback, but we might have older packets in the
middle of the Tx path. These packets will land in the
driver's queues after the latter have been flushed.
Synchronize_net() between netif_carrier_off and drv_flush()
will fix this.

Note that we can't call synchronize_net inside
ieee80211_flush_queues since there are flows that call
ieee80211_flush_queues and don't need synchronize_net()
which is an expensive operation.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
[reword comment to be more accurate]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 9c748934

net/mac80211/mlme.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -2011,6 +2011,9 @@ static void ieee80211_set_disassoc(struct ieee80211_sub_if_data *sdata,
		/* disable per-vif ps */
		ieee80211_recalc_ps_vif(sdata);

		/* make sure ongoing transmission finishes */
		synchronize_net();

		/*
		* drop any frame before deauth/disassoc, this can be data or
		* management frame. Since we are disconnecting, we should not

Admin message