Commit 14f27939 authored by Milan Broz's avatar Milan Broz Committed by Jens Axboe
Browse files

loop: Flush possible running bios when loop device is released. 



When there are still queued bios and reference count
drops to zero, loop device must flush all queued bios.

Otherwise it can lead to situation that caller
closes the device, but some bios are still running
and endio() function call later OOpses when uses
unallocated mempool.

This happens for example when running dm-crypt over loop,
here is typical oops backtrace:

 Oops: 0000 [#1] PREEMPT SMP
 EIP is at mempool_free+0x12/0x6b
...
 crypt_dec_pending+0x50/0x54 [dm_crypt]
 crypt_endio+0x9f/0xa7 [dm_crypt]
 crypt_endio+0x0/0xa7 [dm_crypt]
 bio_endio+0x2b/0x2e
 loop_thread+0x37a/0x3b1
 do_lo_send_aops+0x0/0x165
 autoremove_wake_function+0x0/0x33
 loop_thread+0x0/0x3b1
 kthread+0x3b/0x61
 kthread+0x0/0x61
 kernel_thread_helper+0x7/0x10

(But crash is reproducible with different dm targets
running over loop device too.)

Patch fixes it by flushing the bios in release call,
reusing the flush mechanism for switching backing store.

Signed-off-by: default avatarMilan Broz <mbroz@redhat.com>
Signed-off-by: default avatarJens Axboe <jens.axboe@oracle.com>
parent 10e5b644

drivers/block/loop.c

+35 −3
Original line number Diff line number Diff line
@@ -623,6 +623,18 @@ static int loop_switch(struct loop_device *lo, struct file *file) 
	return 0;

}



/*

 * Helper to flush the IOs in loop, but keeping loop thread running

 */

static int loop_flush(struct loop_device *lo)

{

	/* loop not yet configured, no running thread, nothing to flush */

	if (!lo->lo_thread)

		return 0;



	return loop_switch(lo, NULL);

}



/*

 * Do the actual switch; called from the BIO completion routine

 */
@@ -630,14 +642,20 @@ static void do_loop_switch(struct loop_device *lo, struct switch_request *p) 
{

	struct file *file = p->file;

	struct file *old_file = lo->lo_backing_file;

	struct address_space *mapping = file->f_mapping;

	struct address_space *mapping;



	/* if no new file, only flush of queued bios requested */

	if (!file)

		goto out;



	mapping = file->f_mapping;

	mapping_set_gfp_mask(old_file->f_mapping, lo->old_gfp_mask);

	lo->lo_backing_file = file;

	lo->lo_blocksize = S_ISBLK(mapping->host->i_mode) ?

		mapping->host->i_bdev->bd_block_size : PAGE_SIZE;

	lo->old_gfp_mask = mapping_gfp_mask(mapping);

	mapping_set_gfp_mask(mapping, lo->old_gfp_mask & ~(__GFP_IO|__GFP_FS));

out:

	complete(&p->wait);

}
@@ -1345,11 +1363,25 @@ static int lo_release(struct gendisk *disk, fmode_t mode) 
	struct loop_device *lo = disk->private_data;



	mutex_lock(&lo->lo_ctl_mutex);

	--lo->lo_refcnt;



	if ((lo->lo_flags & LO_FLAGS_AUTOCLEAR) && !lo->lo_refcnt)

	if (--lo->lo_refcnt)

		goto out;



	if (lo->lo_flags & LO_FLAGS_AUTOCLEAR) {

		/*

		 * In autoclear mode, stop the loop thread

		 * and remove configuration after last close.

		 */

		loop_clr_fd(lo, NULL);

	} else {

		/*

		 * Otherwise keep thread (if running) and config,

		 * but flush possible ongoing bios in thread.

		 */

		loop_flush(lo);

	}



out:

	mutex_unlock(&lo->lo_ctl_mutex);



	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE