Commit 14de99b4 authored Aug 28, 2018 by Wolfram Sang Committed by Wim Van Sebroeck Oct 02, 2018

watchdog: renesas_wdt: stop when unregistering

We want to go into a sane state when unregistering. Currently, it
happens that the watchdog stops when unbinding because of RuntimePM
stopping the core clock. When rebinding, the core clock gets reactivated
and the watchdog fires even though it hasn't been opened by userspace
yet. Strange scenario, yes, but sane state is much preferred anyhow.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

parent 953b9dd7

drivers/watchdog/renesas_wdt.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -231,6 +231,7 @@ static int rwdt_probe(struct platform_device *pdev)
		watchdog_set_drvdata(&priv->wdev, priv);
		watchdog_set_nowayout(&priv->wdev, nowayout);
		watchdog_set_restart_priority(&priv->wdev, 0);
		watchdog_stop_on_unregister(&priv->wdev);

		/* This overrides the default timeout only if DT configuration was found */
		ret = watchdog_init_timeout(&priv->wdev, 0, &pdev->dev);