Commit 14ca0bdf authored Aug 03, 2015 by Viresh Kumar Committed by Rafael J. Wysocki Sep 01, 2015

cpufreq: update user_policy.* on success



'user_policy' caches properties of a policy that are set by userspace.
And these must be updated only if cpufreq core was successful in
updating them based on request from user space.

In store_scaling_governor(), we are updating user_policy.policy and
user_policy.governor even if cpufreq_set_policy() failed. That's
incorrect.

Fix this by updating user_policy.* only if we were successful in
updating the properties.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 8fa5b631

drivers/cpufreq/cpufreq.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -671,13 +671,11 @@ static ssize_t store_scaling_governor(struct cpufreq_policy *policy,
		return -EINVAL;

		ret = cpufreq_set_policy(policy, &new_policy);
		if (ret)
		return ret;

		policy->user_policy.policy = policy->policy;
		policy->user_policy.governor = policy->governor;

		if (ret)
		return ret;
		else
		return count;
		}

Admin message