platform/x86: acerhdf: Remove cut-and-paste trap from instructions (14c20688) · Commits · 戴 / test

Just like we avoid specifying actual block devices like sda for fdisk and dd examples, we should not specify specific thermal zones here. On the platform I was testing on, zone0 was acpitz, and zone1 was for this acerhdf driver. Make the printk such that it won't work with a blind cut-and-paste, and force the user to determine which zone is correct for this driver. Cc: Peter Feuerer <peter@piie.net> Cc: Darren Hart <dvhart@infradead.org> Cc: Andy Shevchenko <andy@infradead.org> Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:

Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by:

Peter Feuerer <peter@piie.net>

drivers/platform/x86/Kconfig

+4 −1

Original line number	Diff line number	Diff line
		@@ -60,7 +60,10 @@ config ACERHDF

		After loading this driver the BIOS is still in control of the fan.
		To let the kernel handle the fan, do:
		echo -n enabled > /sys/class/thermal/thermal_zone0/mode
		echo -n enabled > /sys/class/thermal/thermal_zoneN/mode
		where N=0,1,2... depending on the number of thermal nodes and the
		detection order of your particular system. The "type" parameter
		in the same node directory will tell you if it is "acerhdf".

		For more information about this driver see
		<http://piie.net/files/acerhdf_README.txt>

drivers/platform/x86/acerhdf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -688,7 +688,7 @@ static int acerhdf_check_hardware(void)
		*/
		if (!kernelmode) {
		pr_notice("Fan control off, to enable do:\n");
		pr_notice("echo -n \"enabled\" > /sys/class/thermal/thermal_zone0/mode\n");
		pr_notice("echo -n \"enabled\" > /sys/class/thermal/thermal_zoneN/mode # N=0,1,2...\n");
		}

		return 0;

Admin message