Commit 149d7549 authored Mar 20, 2015 by Marcelo Ricardo Leitner Committed by David S. Miller Mar 20, 2015

vxlan: fix possible use of uninitialized in vxlan_igmp_{join, leave}

Test robot noticed that we check the return of vxlan_igmp_join and leave
but inside them there was a path that it could be used initialized.

It's not really possible because those if() inside these igmp functions
would always match as we can't have sockets of other type in there, but
this way we keep the compiler happy.

Fixes: 56ef9c90 ("vxlan: Move socket initialization to within rtnl scope")
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent edafc132

drivers/net/vxlan.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1093,7 +1093,7 @@ static int vxlan_igmp_join(struct vxlan_dev *vxlan)
		struct sock *sk = vs->sock->sk;
		union vxlan_addr *ip = &vxlan->default_dst.remote_ip;
		int ifindex = vxlan->default_dst.remote_ifindex;
		int ret;
		int ret = -EINVAL;

		lock_sock(sk);
		if (ip->sa.sa_family == AF_INET) {
		@@ -1121,7 +1121,7 @@ static int vxlan_igmp_leave(struct vxlan_dev *vxlan)
		struct sock *sk = vs->sock->sk;
		union vxlan_addr *ip = &vxlan->default_dst.remote_ip;
		int ifindex = vxlan->default_dst.remote_ifindex;
		int ret;
		int ret = -EINVAL;

		lock_sock(sk);
		if (ip->sa.sa_family == AF_INET) {

Admin message