Commit 14721add authored Sep 02, 2020 by Qu Wenruo Committed by Jessica Yu Sep 02, 2020

module: Add more error message for failed kernel module loading



When kernel module loading failed, user space only get one of the
following error messages:

- ENOEXEC
  This is the most confusing one. From corrupted ELF header to bad
  WRITE|EXEC flags check introduced by in module_enforce_rwx_sections()
  all returns this error number.

- EPERM
  This is for blacklisted modules. But mod doesn't do extra explain
  on this error either.

- ENOMEM
  The only error which needs no explain.

This means, if a user got "Exec format error" from modprobe, it provides
no meaningful way for the user to debug, and will take extra time
communicating to get extra info.

So this patch will add extra error messages for -ENOEXEC and -EPERM
errors, allowing user to do better debugging and reporting.

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>

parent f75aef39

kernel/module.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -2096,9 +2096,12 @@ static int module_enforce_rwx_sections(Elf_Ehdr hdr, Elf_Shdr sechdrs,
		int i;

		for (i = 0; i < hdr->e_shnum; i++) {
		if ((sechdrs[i].sh_flags & shf_wx) == shf_wx)
		if ((sechdrs[i].sh_flags & shf_wx) == shf_wx) {
		pr_err("%s: section %s (index %d) has invalid WRITE\|EXEC flags\n",
		mod->name, secstrings + sechdrs[i].sh_name, i);
		return -ENOEXEC;
		}
		}

		return 0;
		}
		@@ -3825,8 +3828,10 @@ static int load_module(struct load_info info, const char __user uargs,
		char *after_dashes;

		err = elf_header_check(info);
		if (err)
		if (err) {
		pr_err("Module has invalid ELF header\n");
		goto free_copy;
		}

		err = setup_load_info(info, flags);
		if (err)
		@@ -3834,6 +3839,7 @@ static int load_module(struct load_info info, const char __user uargs,

		if (blacklisted(info->name)) {
		err = -EPERM;
		pr_err("Module %s is blacklisted\n", info->name);
		goto free_copy;
		}

Admin message