Commit 143b65d6 authored by Linus Walleij's avatar Linus Walleij
Browse files

gpio: create an API to detect open drain/source on lines 



My left hand merges code to privatize the descriptor handling
while my right hand merges drivers that poke around and
disrespect with the same gpiolib internals.

So let's expose the proper APIs for drivers to ask the gpiolib
core if a line is marked as open drain or open source and
get some order around things so this driver compiles again.

Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Cc: Nicolas Saenz Julienne <nicolassaenzj@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent d6f434e8

drivers/gpio/gpio-tps65218.c

+4 −5
Original line number Diff line number Diff line
@@ -71,17 +71,16 @@ static int tps65218_gpio_request(struct gpio_chip *gc, unsigned offset) 
{

	struct tps65218_gpio *tps65218_gpio = gpiochip_get_data(gc);

	struct tps65218 *tps65218 = tps65218_gpio->tps65218;

	unsigned long flags = gc->desc[offset].flags;

	int ret;



	if (flags & FLAG_OPEN_SOURCE) {

	if (gpiochip_line_is_open_source(gc, offset)) {

		dev_err(gc->parent, "can't work as open source\n");

		return -EINVAL;

	}



	switch (offset) {

	case 0:

		if (!(flags & FLAG_OPEN_DRAIN)) {

		if (!gpiochip_line_is_open_drain(gc, offset)) {

			dev_err(gc->parent, "GPO1 works only as open drain\n");

			return -EINVAL;

		}
@@ -103,7 +102,7 @@ static int tps65218_gpio_request(struct gpio_chip *gc, unsigned offset) 
		break;

	case 1:

		/* GP02 is push-pull by default, can be set as open drain. */

		if (flags & FLAG_OPEN_DRAIN) {

		if (gpiochip_line_is_open_drain(gc, offset)) {

			ret = tps65218_clear_bits(tps65218,

						  TPS65218_REG_CONFIG1,

						  TPS65218_CONFIG1_GPO2_BUF,
@@ -122,7 +121,7 @@ static int tps65218_gpio_request(struct gpio_chip *gc, unsigned offset) 
		break;



	case 2:

		if (!(flags & FLAG_OPEN_DRAIN)) {

		if (!gpiochip_line_is_open_drain(gc, offset)) {

			dev_err(gc->parent, "GPO3 works only as open drain\n");

			return -EINVAL;

		}

drivers/gpio/gpiolib.c

+18 −0
Original line number Diff line number Diff line
@@ -1901,6 +1901,24 @@ bool gpiochip_line_is_irq(struct gpio_chip *chip, unsigned int offset) 
}

EXPORT_SYMBOL_GPL(gpiochip_line_is_irq);



bool gpiochip_line_is_open_drain(struct gpio_chip *chip, unsigned int offset)

{

	if (offset >= chip->ngpio)

		return false;



	return test_bit(FLAG_OPEN_DRAIN, &chip->gpiodev->descs[offset].flags);

}

EXPORT_SYMBOL_GPL(gpiochip_line_is_open_drain);



bool gpiochip_line_is_open_source(struct gpio_chip *chip, unsigned int offset)

{

	if (offset >= chip->ngpio)

		return false;



	return test_bit(FLAG_OPEN_SOURCE, &chip->gpiodev->descs[offset].flags);

}

EXPORT_SYMBOL_GPL(gpiochip_line_is_open_source);



/**

 * gpiod_get_raw_value_cansleep() - return a gpio's raw value

 * @desc: gpio whose value will be returned

include/linux/gpio/driver.h

+4 −0
Original line number Diff line number Diff line
@@ -199,6 +199,10 @@ int gpiochip_lock_as_irq(struct gpio_chip *chip, unsigned int offset); 
void gpiochip_unlock_as_irq(struct gpio_chip *chip, unsigned int offset);

bool gpiochip_line_is_irq(struct gpio_chip *chip, unsigned int offset);



/* Line status inquiry for drivers */

bool gpiochip_line_is_open_drain(struct gpio_chip *chip, unsigned int offset);

bool gpiochip_line_is_open_source(struct gpio_chip *chip, unsigned int offset);



/* get driver data */

void *gpiochip_get_data(struct gpio_chip *chip);

CRA Git | Maintained and supported by SUSTech CRA and CCSE