Commit 143ad322 authored by Srinivas Pandruvada's avatar Srinivas Pandruvada Committed by Andy Shevchenko
Browse files

tools/power/x86/intel-speed-select: Enhance core-power info command 



In addition to CLOS enable status, also show the core-power feature
status. This will help why clos enable status didn't give desired
results as the core-power feature may be disabled or unsupported.

The new display looks as follows:

$intel-speed-select core-power info
Intel(R) Speed Select Technology
..
 package-0
  die-0
    cpu-0
      core-power
        support-status:supported
        enable-status:enabled
        clos-enable-status:1
        priority-type:0

In the above display "support-status" and "enable-status", shows the
status of the core-power feature and "clos-enable-status", shows the
status of the clos.

Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent f5205f49

tools/power/x86/intel-speed-select/isst-config.c

+7 −2
Original line number Diff line number Diff line
@@ -1754,8 +1754,13 @@ static void get_clos_info_for_cpu(int cpu, void *arg1, void *arg2, void *arg3, 
	ret = isst_clos_get_clos_information(cpu, &enable, &prio_type);

	if (ret)

		perror("isst_clos_get_info");

	else

		isst_clos_display_clos_information(cpu, outf, enable, prio_type);

	else {

		int cp_state, cp_cap;



		isst_read_pm_config(cpu, &cp_state, &cp_cap);

		isst_clos_display_clos_information(cpu, outf, enable, prio_type,

						   cp_state, cp_cap);

	}

}



static void dump_clos_info(int arg)

tools/power/x86/intel-speed-select/isst-display.c

+16 −1
Original line number Diff line number Diff line
@@ -589,7 +589,8 @@ void isst_clos_display_information(int cpu, FILE *outf, int clos, 
}



void isst_clos_display_clos_information(int cpu, FILE *outf,

					int clos_enable, int type)

					int clos_enable, int type,

					int state, int cap)

{

	char header[256];

	char value[256];
@@ -605,7 +606,21 @@ void isst_clos_display_clos_information(int cpu, FILE *outf, 
	snprintf(header, sizeof(header), "core-power");

	format_and_print(outf, 4, header, NULL);



	snprintf(header, sizeof(header), "support-status");

	if (cap)

		snprintf(value, sizeof(value), "supported");

	else

		snprintf(value, sizeof(value), "unsupported");

	format_and_print(outf, 5, header, value);



	snprintf(header, sizeof(header), "enable-status");

	if (state)

		snprintf(value, sizeof(value), "enabled");

	else

		snprintf(value, sizeof(value), "disabled");

	format_and_print(outf, 5, header, value);



	snprintf(header, sizeof(header), "clos-enable-status");

	snprintf(value, sizeof(value), "%d", clos_enable);

	format_and_print(outf, 5, header, value);

tools/power/x86/intel-speed-select/isst.h

+3 −1
Original line number Diff line number Diff line
@@ -245,7 +245,9 @@ extern void isst_display_result(int cpu, FILE *outf, char *feature, char *cmd, 


extern int isst_clos_get_clos_information(int cpu, int *enable, int *type);

extern void isst_clos_display_clos_information(int cpu, FILE *outf,

					       int clos_enable, int type);

					       int clos_enable, int type,

					       int state, int cap);

extern int is_clx_n_platform(void);

extern int get_cpufreq_base_freq(int cpu);

extern int isst_read_pm_config(int cpu, int *cp_state, int *cp_cap);

#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE