Commit 1437a30a authored Dec 06, 2010 by Ian Munsie Committed by Arnaldo Carvalho de Melo Dec 06, 2010

perf hist: Better displaying of unresolved DSOs and symbols



In the event that a DSO has not been identified, just print out [unknown]
instead of the instruction pointer as we previously were doing, which is pretty
meaningless for a shared object (at least to the users perspective).

The IP we print out is fairly meaningless in general anyway - it's just one
(the first) of the many addresses that were lumped together as unidentified,
and could span many shared objects and symbols. In reality if we see this
[unknown] output then the report -D output is going to be more useful anyway as
we can see all the different address that it represents.

If we are printing the symbols we are still going to see this IP in that column
anyway since they shouldn't resolve either.

This patch also changes the symbol address printouts so that they print out 0x
before the address, are left aligned, and changes the %L format string (which
relies on a glibc bug) to %ll.

Before:
    74.11%    :3259               4a6c  [k]     4a6c
After:
    74.11%    :3259  [unknown]          [k] 0x4a6c

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <1291603026-11785-2-git-send-email-imunsie@au1.ibm.com>
Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 9c90a61c

tools/perf/util/sort.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -170,7 +170,7 @@ static int hist_entry__dso_snprintf(struct hist_entry self, char bf,
		return repsep_snprintf(bf, size, "%-*s", width, dso_name);
		}

		return repsep_snprintf(bf, size, "%*Lx", width, self->ip);
		return repsep_snprintf(bf, size, "%-*s", width, "[unknown]");
		}

		/* --sort symbol */
		@@ -196,7 +196,7 @@ static int hist_entry__sym_snprintf(struct hist_entry self, char bf,

		if (verbose) {
		char o = self->ms.map ? dso__symtab_origin(self->ms.map->dso) : '!';
		ret += repsep_snprintf(bf, size, "%*Lx %c ",
		ret += repsep_snprintf(bf, size, "%-#*llx %c ",
		BITS_PER_LONG / 4, self->ip, o);
		}

		@@ -205,7 +205,7 @@ static int hist_entry__sym_snprintf(struct hist_entry self, char bf,
		ret += repsep_snprintf(bf + ret, size - ret, "%s",
		self->ms.sym->name);
		else
		ret += repsep_snprintf(bf + ret, size - ret, "%*Lx",
		ret += repsep_snprintf(bf + ret, size - ret, "%-#*llx",
		BITS_PER_LONG / 4, self->ip);

		return ret;

Admin message