Commit 143780c6 authored Apr 11, 2011 by Allan, Bruce W Committed by David S. Miller Apr 12, 2011

ethtool: time to blink provided in seconds not jiffies



When blinking for a duration set by the user, the value specified is in
seconds but it is used as the number of jiffies in the timeout after which
the Physical ID indicator is deactivated.  Fix by converting the timeout
to seconds.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Acked-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6ba1037c

net/core/ethtool.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1653,7 +1653,7 @@ static int ethtool_phys_id(struct net_device dev, void __user useraddr)
		if (rc == 0) {
		/* Driver will handle this itself */
		schedule_timeout_interruptible(
		id.data ? id.data : MAX_SCHEDULE_TIMEOUT);
		id.data ? (id.data * HZ) : MAX_SCHEDULE_TIMEOUT);
		} else {
		/* Driver expects to be called periodically */
		do {

Admin message