Commit 1411b521 authored by Michael Ellerman's avatar Michael Ellerman Committed by Herbert Xu
Browse files

crypto: vmx - Remove overly verbose printk from AES init routines 



In the vmx AES init routines we do a printk(KERN_INFO ...) to report
the fallback implementation we're using.

However with a slow console this can significantly affect the speed of
crypto operations. Using 'cryptsetup benchmark' the removal of the
printk() leads to a ~5x speedup for aes-cbc decryption.

So remove them.

Fixes: 8676590a ("crypto: vmx - Adding AES routines for VMX module")
Fixes: 8c755ace ("crypto: vmx - Adding CBC routines for VMX module")
Fixes: 4f7f60d3 ("crypto: vmx - Adding CTR routines for VMX module")
Fixes: cc333cd6 ("crypto: vmx - Adding GHASH routines for VMX module")
Cc: stable@vger.kernel.org # v4.1+
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 6caf7adc

drivers/crypto/vmx/aes.c

+0 −2
Original line number Diff line number Diff line
@@ -48,8 +48,6 @@ static int p8_aes_init(struct crypto_tfm *tfm) 
		       alg, PTR_ERR(fallback));

		return PTR_ERR(fallback);

	}

	printk(KERN_INFO "Using '%s' as fallback implementation.\n",

	       crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback));



	crypto_cipher_set_flags(fallback,

				crypto_cipher_get_flags((struct

drivers/crypto/vmx/aes_cbc.c

+0 −3
Original line number Diff line number Diff line
@@ -52,9 +52,6 @@ static int p8_aes_cbc_init(struct crypto_tfm *tfm) 
		       alg, PTR_ERR(fallback));

		return PTR_ERR(fallback);

	}

	printk(KERN_INFO "Using '%s' as fallback implementation.\n",

		crypto_skcipher_driver_name(fallback));





	crypto_skcipher_set_flags(

		fallback,

drivers/crypto/vmx/aes_ctr.c

+0 −2
Original line number Diff line number Diff line
@@ -50,8 +50,6 @@ static int p8_aes_ctr_init(struct crypto_tfm *tfm) 
		       alg, PTR_ERR(fallback));

		return PTR_ERR(fallback);

	}

	printk(KERN_INFO "Using '%s' as fallback implementation.\n",

		crypto_skcipher_driver_name(fallback));



	crypto_skcipher_set_flags(

		fallback,

drivers/crypto/vmx/ghash.c

+0 −2
Original line number Diff line number Diff line
@@ -64,8 +64,6 @@ static int p8_ghash_init_tfm(struct crypto_tfm *tfm) 
		       alg, PTR_ERR(fallback));

		return PTR_ERR(fallback);

	}

	printk(KERN_INFO "Using '%s' as fallback implementation.\n",

	       crypto_tfm_alg_driver_name(crypto_shash_tfm(fallback)));



	crypto_shash_set_flags(fallback,

			       crypto_shash_get_flags((struct crypto_shash

CRA Git | Maintained and supported by SUSTech CRA and CCSE