Commit 140ff891 authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt
Browse files

ring-buffer: Remove condition to add timestamp in fast path 



There's a condition to check if we should add a time extend or
not in the fast path. But this condition is racey (in the sense
that we can add a unnecessary time extend, but nothing that
can break anything). We later check if the time or event time
delta should be zero or have real data in it (not racey), making
this first check redundant.

This check may help save space once in a while, but really is
not worth the hassle to try to save some space that happens at
most 134 ms at a time.

Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
parent 69d1b839

kernel/trace/ring_buffer.c

+6 −22
Original line number Diff line number Diff line
@@ -2119,6 +2119,7 @@ rb_reserve_next_event(struct ring_buffer *buffer, 
	u64 ts, delta;

	int nr_loops = 0;

	int add_timestamp;

	u64 diff;



	rb_start_commit(cpu_buffer);
@@ -2155,29 +2156,13 @@ rb_reserve_next_event(struct ring_buffer *buffer, 
		goto out_fail;



	ts = rb_time_stamp(cpu_buffer->buffer);



	/*

	 * Only the first commit can update the timestamp.

	 * Yes there is a race here. If an interrupt comes in

	 * just after the conditional and it traces too, then it

	 * will also check the deltas. More than one timestamp may

	 * also be made. But only the entry that did the actual

	 * commit will be something other than zero.

	 */

	if (likely(cpu_buffer->tail_page == cpu_buffer->commit_page &&

		   rb_page_write(cpu_buffer->tail_page) ==

		   rb_commit_index(cpu_buffer))) {

		u64 diff;



	diff = ts - cpu_buffer->write_stamp;



	/* make sure this diff is calculated here */

	barrier();



	/* Did the write stamp get updated already? */

		if (unlikely(ts < cpu_buffer->write_stamp))

			goto get_event;



	if (likely(ts >= cpu_buffer->write_stamp)) {

		delta = diff;

		if (unlikely(test_time_stamp(delta))) {

			WARN_ONCE(delta > (1ULL << 59),
@@ -2189,7 +2174,6 @@ rb_reserve_next_event(struct ring_buffer *buffer, 
		}

	}



 get_event:

	event = __rb_reserve_next(cpu_buffer, length, ts,

				  delta, add_timestamp);

	if (unlikely(PTR_ERR(event) == -EAGAIN))

CRA Git | Maintained and supported by SUSTech CRA and CCSE