Commit 140e807d authored by Eric W. Biederman's avatar Eric W. Biederman Committed by David S. Miller
Browse files

tun: Utilize the normal socket network namespace refcounting. 



There is no need for tun to do the weird network namespace refcounting.
The existing network namespace refcounting in tfile has almost exactly
the same lifetime.  So rewrite the code to use the struct sock network
namespace refcounting and remove the unnecessary hand rolled network
namespace refcounting and the unncesary tfile->net.

This change allows the tun code to directly call sock_put bypassing
sock_release and making SOCK_EXTERNALLY_ALLOCATED unnecessary.

Remove the now unncessary tun_release so that if anything tries to use
the sock_release code path the kernel will oops, and let us know about
the bug.

The macvtap code already uses it's internal socket this way.

Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 80ba92fa

drivers/net/tun.c

+4 −20
Original line number Diff line number Diff line
@@ -146,7 +146,6 @@ struct tun_file { 
	struct socket socket;

	struct socket_wq wq;

	struct tun_struct __rcu *tun;

	struct net *net;

	struct fasync_struct *fasync;

	/* only used for fasnyc */

	unsigned int flags;
@@ -493,10 +492,7 @@ static void __tun_detach(struct tun_file *tfile, bool clean) 
			    tun->dev->reg_state == NETREG_REGISTERED)

				unregister_netdevice(tun->dev);

		}



		BUG_ON(!test_bit(SOCK_EXTERNALLY_ALLOCATED,

				 &tfile->socket.flags));

		sk_release_kernel(&tfile->sk);

		sock_put(&tfile->sk);

	}

}
@@ -1492,18 +1488,10 @@ out: 
	return ret;

}



static int tun_release(struct socket *sock)

{

	if (sock->sk)

		sock_put(sock->sk);

	return 0;

}



/* Ops structure to mimic raw sockets with tun */

static const struct proto_ops tun_socket_ops = {

	.sendmsg = tun_sendmsg,

	.recvmsg = tun_recvmsg,

	.release = tun_release,

};



static struct proto tun_proto = {
@@ -1865,7 +1853,7 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd, 
	if (cmd == TUNSETIFF && !tun) {

		ifr.ifr_name[IFNAMSIZ-1] = '\0';



		ret = tun_set_iff(tfile->net, file, &ifr);

		ret = tun_set_iff(sock_net(&tfile->sk), file, &ifr);



		if (ret)

			goto unlock;
@@ -2154,16 +2142,16 @@ out: 


static int tun_chr_open(struct inode *inode, struct file * file)

{

	struct net *net = current->nsproxy->net_ns;

	struct tun_file *tfile;



	DBG1(KERN_INFO, "tunX: tun_chr_open\n");



	tfile = (struct tun_file *)sk_alloc(&init_net, AF_UNSPEC, GFP_KERNEL,

	tfile = (struct tun_file *)sk_alloc(net, AF_UNSPEC, GFP_KERNEL,

					    &tun_proto);

	if (!tfile)

		return -ENOMEM;

	RCU_INIT_POINTER(tfile->tun, NULL);

	tfile->net = get_net(current->nsproxy->net_ns);

	tfile->flags = 0;

	tfile->ifindex = 0;
@@ -2174,13 +2162,11 @@ static int tun_chr_open(struct inode *inode, struct file * file) 
	tfile->socket.ops = &tun_socket_ops;



	sock_init_data(&tfile->socket, &tfile->sk);

	sk_change_net(&tfile->sk, tfile->net);



	tfile->sk.sk_write_space = tun_sock_write_space;

	tfile->sk.sk_sndbuf = INT_MAX;



	file->private_data = tfile;

	set_bit(SOCK_EXTERNALLY_ALLOCATED, &tfile->socket.flags);

	INIT_LIST_HEAD(&tfile->next);



	sock_set_flag(&tfile->sk, SOCK_ZEROCOPY);
@@ -2191,10 +2177,8 @@ static int tun_chr_open(struct inode *inode, struct file * file) 
static int tun_chr_close(struct inode *inode, struct file *file)

{

	struct tun_file *tfile = file->private_data;

	struct net *net = tfile->net;



	tun_detach(tfile, true);

	put_net(net);



	return 0;

}

include/linux/net.h

+0 −1
Original line number Diff line number Diff line
@@ -38,7 +38,6 @@ struct net; 
#define SOCK_NOSPACE		2

#define SOCK_PASSCRED		3

#define SOCK_PASSSEC		4

#define SOCK_EXTERNALLY_ALLOCATED 5



#ifndef ARCH_HAS_SOCKET_TYPES

/**

net/socket.c

+0 −3
Original line number Diff line number Diff line
@@ -576,9 +576,6 @@ void sock_release(struct socket *sock) 
	if (rcu_dereference_protected(sock->wq, 1)->fasync_list)

		pr_err("%s: fasync list not empty!\n", __func__);



	if (test_bit(SOCK_EXTERNALLY_ALLOCATED, &sock->flags))

		return;



	this_cpu_sub(sockets_in_use, 1);

	if (!sock->file) {

		iput(SOCK_INODE(sock));

CRA Git | Maintained and supported by SUSTech CRA and CCSE