Commit 14067ff5 authored Jul 25, 2011 by Linus Torvalds

vfs: make gcc generate more obvious code for acl permission checking



The "fsuid is the inode owner" case is not necessarily always the likely
case, but it's the case that doesn't do anything odd and that we want in
straight-line code.  Make gcc not generate random "jump around for the
fun of it" code.

This just helps me read profiles.  That thing is one of the hottest
parts of the whole pathname lookup.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 750e0699

fs/namei.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -235,7 +235,7 @@ static int acl_permission_check(struct inode *inode, int mask)
		if (current_user_ns() != inode_userns(inode))
		goto other_perms;

		if (current_fsuid() == inode->i_uid)
		if (likely(current_fsuid() == inode->i_uid))
		mode >>= 6;
		else {
		if (IS_POSIXACL(inode) && (mode & S_IRWXG)) {

Admin message