Revert "rt2800: enable TX_PIN_CFG_LNA_PE_ bits per band" (13fa4515) · Commits · 戴 / test

This reverts commit . As reported by Sergey: "I got some problem after upgrade kernel to 5.2 version (debian testing linux-image-5.2.0-2-amd64). 5Ghz client stopped to see AP. Some tests with 1metre distance between client-AP: 2.4Ghz -22dBm, for 5Ghz - 53dBm !, for longer distance (8m + walls) 2.4 - 61dBm, 5Ghz not visible." It was identified that rx signal level degradation was caused by ("rt2800: enable TX_PIN_CFG_LNA_PE_ bits per band"). So revert this commit. Cc: <stable@vger.kernel.org> # v5.1+ Reported-and-tested-by:

Sergey Maranchuk <slav0nic0@gmail.com> Signed-off-by:

Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/ralink/rt2x00/rt2800lib.c

+6 −12

Original line number	Diff line number	Diff line
		@@ -4242,24 +4242,18 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
		switch (rt2x00dev->default_ant.rx_chain_num) {
		case 3:
		/* Turn on tertiary LNAs */
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_A2_EN,
		rf->channel > 14);
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_G2_EN,
		rf->channel <= 14);
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_A2_EN, 1);
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_G2_EN, 1);
		/* fall-through */
		case 2:
		/* Turn on secondary LNAs */
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_A1_EN,
		rf->channel > 14);
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_G1_EN,
		rf->channel <= 14);
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_A1_EN, 1);
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_G1_EN, 1);
		/* fall-through */
		case 1:
		/* Turn on primary LNAs */
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_A0_EN,
		rf->channel > 14);
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_G0_EN,
		rf->channel <= 14);
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_A0_EN, 1);
		rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_G0_EN, 1);
		break;
		}

Admin message