Commit 13c41737 authored May 09, 2019 by Dan Carpenter Committed by Ilya Dryomov Jul 08, 2019

ceph: silence a checker warning in mdsc_show()



The problem is that if ceph_mdsc_build_path() fails then we set "path"
to NULL and the "pathlen" variable is uninitialized.  Then we call
ceph_mdsc_free_path(path, pathlen) to clean up.  Since "path" is NULL,
the function is a no-op but Smatch and UBSan still complain that
"pathlen" is uninitialized.

This patch doesn't change run time, it just silence the warnings.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent 97a385e5

fs/ceph/debugfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -52,7 +52,7 @@ static int mdsc_show(struct seq_file s, void p)
		struct ceph_mds_client *mdsc = fsc->mdsc;
		struct ceph_mds_request *req;
		struct rb_node *rp;
		int pathlen;
		int pathlen = 0;
		u64 pathbase;
		char *path;

Admin message