Commit 13c3ab86 authored Oct 26, 2010 by Julia Lawall Committed by David S. Miller Oct 27, 2010

drivers/net/typhoon.c: delete double assignment

Delete successive assignments to the same location.  The current definition
does not initialize the respRing structure, which has the same type as the
cmdRing structure, so initialize that one instead.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression i;
@@

*i = ...;
 i = ...;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: David Dillow <dave@thedillows.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d58c0e95

drivers/net/typhoon.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1300,7 +1300,7 @@ typhoon_init_rings(struct typhoon *tp)
		tp->rxHiRing.lastWrite = 0;
		tp->rxBuffRing.lastWrite = 0;
		tp->cmdRing.lastWrite = 0;
		tp->cmdRing.lastWrite = 0;
		tp->respRing.lastWrite = 0;

		tp->txLoRing.lastRead = 0;
		tp->txHiRing.lastRead = 0;

Admin message