Commit 13c1d4b3 authored by Rishi Gupta's avatar Rishi Gupta Committed by Greg Kroah-Hartman
Browse files

toshiba: Add correct printk log level while emitting error log 



The printk functions are invoked without specifying required
log level when printing error messages. This commit replaces
all direct uses of printk with their corresponding pr_err/info/debug
variant.

Signed-off-by: default avatarRishi Gupta <gupt21@gmail.com>
Link: https://lore.kernel.org/r/1566113671-8743-1-git-send-email-gupt21@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cf61860e

drivers/char/toshiba.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -373,7 +373,7 @@ static int tosh_get_machine_id(void __iomem *bios) 
		   value. This has been verified on a Satellite Pro 430CDT,

		   value. This has been verified on a Satellite Pro 430CDT,

		   Tecra 750CDT, Tecra 780DVD and Satellite 310CDT. */

		   Tecra 750CDT, Tecra 780DVD and Satellite 310CDT. */

#if TOSH_DEBUG

#if TOSH_DEBUG

		printk("toshiba: debugging ID ebx=0x%04x\n", regs.ebx);

		pr_debug("toshiba: debugging ID ebx=0x%04x\n", regs.ebx);

#endif

#endif

		bx = 0xe6f5;

		bx = 0xe6f5;
@@ -417,7 +417,7 @@ static int tosh_probe(void) 




	for (i=0;i<7;i++) {

	for (i=0;i<7;i++) {

		if (readb(bios+0xe010+i)!=signature[i]) {

		if (readb(bios+0xe010+i)!=signature[i]) {

			printk("toshiba: not a supported Toshiba laptop\n");

			pr_err("toshiba: not a supported Toshiba laptop\n");

			iounmap(bios);

			iounmap(bios);

			return -ENODEV;

			return -ENODEV;

		}

		}
@@ -433,7 +433,7 @@ static int tosh_probe(void) 
	/* if this is not a Toshiba laptop carry flag is set and ah=0x86 */

	/* if this is not a Toshiba laptop carry flag is set and ah=0x86 */





	if ((flag==1) || ((regs.eax & 0xff00)==0x8600)) {

	if ((flag==1) || ((regs.eax & 0xff00)==0x8600)) {

		printk("toshiba: not a supported Toshiba laptop\n");

		pr_err("toshiba: not a supported Toshiba laptop\n");

		iounmap(bios);

		iounmap(bios);

		return -ENODEV;

		return -ENODEV;

	}

	}
@@ -486,7 +486,7 @@ static int __init toshiba_init(void) 
	if (tosh_probe())

	if (tosh_probe())

		return -ENODEV;

		return -ENODEV;





	printk(KERN_INFO "Toshiba System Management Mode driver v" TOSH_VERSION "\n");

	pr_info("Toshiba System Management Mode driver v" TOSH_VERSION "\n");





	/* set the port to use for Fn status if not specified as a parameter */

	/* set the port to use for Fn status if not specified as a parameter */

	if (tosh_fn==0x00)

	if (tosh_fn==0x00)

CRA Git | Maintained and supported by SUSTech CRA and CCSE