Commit 13c060b5 authored Apr 03, 2020 by Alex Elder Committed by Bjorn Andersson Apr 16, 2020

remoteproc: qcom_q6v5_mss: fix a bug in q6v5_probe()



If looking up the DT "firmware-name" property fails in q6v6_probe(),
the function returns without freeing the remoteproc structure
that has been allocated.  Fix this by jumping to the free_rproc
label, which takes care of this.

Signed-off-by: Alex Elder <elder@linaro.org>
Link: https://lore.kernel.org/r/20200403175005.17130-3-elder@linaro.org


Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

parent 8f3d9f35

drivers/remoteproc/qcom_q6v5_mss.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1675,7 +1675,7 @@ static int q6v5_probe(struct platform_device *pdev)
		ret = of_property_read_string_index(pdev->dev.of_node, "firmware-name",
		1, &qproc->hexagon_mdt_image);
		if (ret < 0 && ret != -EINVAL)
		return ret;
		goto free_rproc;

		platform_set_drvdata(pdev, qproc);

Admin message