Commit 139a5617 authored Mar 18, 2019 by Nikolay Borisov Committed by David Sterba Mar 19, 2019

btrfs: Avoid possible qgroup_rsv_size overflow in btrfs_calculate_inode_block_rsv_size



qgroup_rsv_size is calculated as the product of
outstanding_extent * fs_info->nodesize. The product is calculated with
32 bit precision since both variables are defined as u32. Yet
qgroup_rsv_size expects a 64 bit result.

Avoid possible multiplication overflow by casting outstanding_extent to
u64. Such overflow would in the worst case (64K nodesize) require more
than 65536 extents, which is quite large and i'ts not likely that it
would happen in practice.

Fixes-coverity-id: 1435101
Fixes: ff6bc37e ("btrfs: qgroup: Use independent and accurate per inode qgroup rsv")
CC: stable@vger.kernel.org # 4.19+
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 7ff2c2a1

fs/btrfs/extent-tree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -6174,7 +6174,7 @@ static void btrfs_calculate_inode_block_rsv_size(struct btrfs_fs_info *fs_info,
		*
		* This is overestimating in most cases.
		*/
		qgroup_rsv_size = outstanding_extents * fs_info->nodesize;
		qgroup_rsv_size = (u64)outstanding_extents * fs_info->nodesize;

		spin_lock(&block_rsv->lock);
		block_rsv->size = reserve_size;

Admin message