SMB3: add support for recognizing WSL reparse tags (13909d96) · Commits · 戴 / test

The IO_REPARSE_TAG_LX_ tags originally were used by WSL but they are preferred by the Linux client in some cases since, unlike the NFS reparse tag (or EAs), they don't require an extra query to determine which type of special file they represent. Add support for readdir to recognize special file types of FIFO, SOCKET, CHAR, BLOCK and SYMLINK. This can be tested by creating these special files in WSL Linux and then sharing that location on the Windows server and mounting to the Windows server to access them. Prior to this patch all of the special files would show up as being of type 'file' but with this patch they can be seen with the correct file type as can be seen below: brwxr-xr-x 1 root root 0, 0 Oct 21 17:10 block crwxr-xr-x 1 root root 0, 0 Oct 21 17:46 char drwxr-xr-x 2 root root 0 Oct 21 18:27 dir prwxr-xr-x 1 root root 0 Oct 21 16:21 fifo -rwxr-xr-x 1 root root 0 Oct 21 15:48 file lrwxr-xr-x 1 root root 0 Oct 21 15:52 symlink-to-file TODO: go through all documented reparse tags to see if we can reasonably map some of them to directories vs. files vs. symlinks and also add support for device numbers for block and char devices. Signed-off-by:

Steve French <stfrench@microsoft.com> Reviewed-by:

Aurelien Aptel <aaptel@suse.com>

fs/cifs/readdir.c

+24 −1

Original line number	Diff line number	Diff line
		@@ -168,10 +168,33 @@ cifs_fill_common_info(struct cifs_fattr fattr, struct cifs_sb_info cifs_sb)
		fattr->cf_uid = cifs_sb->mnt_uid;
		fattr->cf_gid = cifs_sb->mnt_gid;

		/*
		* The IO_REPARSE_TAG_LX_ tags originally were used by WSL but they
		* are preferred by the Linux client in some cases since, unlike
		* the NFS reparse tag (or EAs), they don't require an extra query
		* to determine which type of special file they represent.
		* TODO: go through all documented reparse tags to see if we can
		* reasonably map some of them to directories vs. files vs. symlinks
		*/
		if (fattr->cf_cifsattrs & ATTR_DIRECTORY) {
		fattr->cf_mode = S_IFDIR \| cifs_sb->mnt_dir_mode;
		fattr->cf_dtype = DT_DIR;
		} else {
		} else if (fattr->cf_cifstag == IO_REPARSE_TAG_LX_SYMLINK) {
		fattr->cf_mode \|= S_IFLNK \| cifs_sb->mnt_file_mode;
		fattr->cf_dtype = DT_LNK;
		} else if (fattr->cf_cifstag == IO_REPARSE_TAG_LX_FIFO) {
		fattr->cf_mode \|= S_IFIFO \| cifs_sb->mnt_file_mode;
		fattr->cf_dtype = DT_FIFO;
		} else if (fattr->cf_cifstag == IO_REPARSE_TAG_AF_UNIX) {
		fattr->cf_mode \|= S_IFSOCK \| cifs_sb->mnt_file_mode;
		fattr->cf_dtype = DT_SOCK;
		} else if (fattr->cf_cifstag == IO_REPARSE_TAG_LX_CHR) {
		fattr->cf_mode \|= S_IFCHR \| cifs_sb->mnt_file_mode;
		fattr->cf_dtype = DT_CHR;
		} else if (fattr->cf_cifstag == IO_REPARSE_TAG_LX_BLK) {
		fattr->cf_mode \|= S_IFBLK \| cifs_sb->mnt_file_mode;
		fattr->cf_dtype = DT_BLK;
		} else { /* TODO: should we mark some other reparse points (like DFSR) as directories? */
		fattr->cf_mode = S_IFREG \| cifs_sb->mnt_file_mode;
		fattr->cf_dtype = DT_REG;
		}

Admin message