Commit 138ef018 authored by Ira Snyder's avatar Ira Snyder Committed by Li Yang
Browse files

fsldma: fix "DMA halt timeout!" errors 



When using the DMA controller from multiple threads at the same time, it is
possible to get lots of "DMA halt timeout!" errors printed to the kernel
log.

This occurs due to a race between fsl_dma_memcpy_issue_pending() and the
interrupt handler, fsl_dma_chan_do_interrupt(). Both call the
fsl_chan_xfer_ld_queue() function, which does not protect against
concurrent accesses to dma_halt() and dma_start().

The existing spinlock is moved to cover the dma_halt() and dma_start()
functions. Testing shows that the "DMA halt timeout!" errors disappear.

Signed-off-by: default avatarIra W. Snyder <iws@ovro.caltech.edu>
Signed-off-by: default avatarLi Yang <leoli@freescale.com>
parent f47edc6d

drivers/dma/fsldma.c

+6 −4
Original line number Original line Diff line number Diff line
@@ -598,15 +598,16 @@ static void fsl_chan_xfer_ld_queue(struct fsl_dma_chan *fsl_chan) 
	dma_addr_t next_dest_addr;

	dma_addr_t next_dest_addr;

	unsigned long flags;

	unsigned long flags;





	spin_lock_irqsave(&fsl_chan->desc_lock, flags);



	if (!dma_is_idle(fsl_chan))

	if (!dma_is_idle(fsl_chan))

		return;

		goto out_unlock;





	dma_halt(fsl_chan);

	dma_halt(fsl_chan);





	/* If there are some link descriptors

	/* If there are some link descriptors

	 * not transfered in queue. We need to start it.

	 * not transfered in queue. We need to start it.

	 */

	 */

	spin_lock_irqsave(&fsl_chan->desc_lock, flags);





	/* Find the first un-transfer desciptor */

	/* Find the first un-transfer desciptor */

	for (ld_node = fsl_chan->ld_queue.next;

	for (ld_node = fsl_chan->ld_queue.next;
@@ -617,8 +618,6 @@ static void fsl_chan_xfer_ld_queue(struct fsl_dma_chan *fsl_chan) 
				fsl_chan->common.cookie) == DMA_SUCCESS);

				fsl_chan->common.cookie) == DMA_SUCCESS);

		ld_node = ld_node->next);

		ld_node = ld_node->next);





	spin_unlock_irqrestore(&fsl_chan->desc_lock, flags);



	if (ld_node != &fsl_chan->ld_queue) {

	if (ld_node != &fsl_chan->ld_queue) {

		/* Get the ld start address from ld_queue */

		/* Get the ld start address from ld_queue */

		next_dest_addr = to_fsl_desc(ld_node)->async_tx.phys;

		next_dest_addr = to_fsl_desc(ld_node)->async_tx.phys;
@@ -630,6 +629,9 @@ static void fsl_chan_xfer_ld_queue(struct fsl_dma_chan *fsl_chan) 
		set_cdar(fsl_chan, 0);

		set_cdar(fsl_chan, 0);

		set_ndar(fsl_chan, 0);

		set_ndar(fsl_chan, 0);

	}

	}



out_unlock:

	spin_unlock_irqrestore(&fsl_chan->desc_lock, flags);

}

}





/**

/**

CRA Git | Maintained and supported by SUSTech CRA and CCSE