Commit 1385b811 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFS: Fix sparse warnings 



Fix the following sparse warnings:

fs/nfs/direct.c:221:6: warning: symbol 'nfs_direct_readpage_release' was
not declared. Should it be static?
fs/nfs/read.c:38:43: warning: non-ANSI function declaration of function
'nfs_readhdr_alloc'
fs/nfs/objlayout/objio_osd.c:214:5: warning: symbol '__alloc_objio_seg'
was not declared. Should it be static?

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
Cc: Fred Isaman <iisaman@netapp.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>
parent bf5fc402

fs/nfs/direct.c

+1 −1
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ static void nfs_direct_complete(struct nfs_direct_req *dreq) 
	nfs_direct_req_release(dreq);

}



void nfs_direct_readpage_release(struct nfs_page *req)

static void nfs_direct_readpage_release(struct nfs_page *req)

{

	dprintk("NFS: direct read done (%s/%lld %d@%lld)\n",

		req->wb_context->dentry->d_inode->i_sb->s_id,

fs/nfs/objlayout/objio_osd.c

+1 −1
Original line number Diff line number Diff line
@@ -211,7 +211,7 @@ static void copy_single_comp(struct ore_components *oc, unsigned c, 
	memcpy(ocomp->cred, src_comp->oc_cap.cred, sizeof(ocomp->cred));

}



int __alloc_objio_seg(unsigned numdevs, gfp_t gfp_flags,

static int __alloc_objio_seg(unsigned numdevs, gfp_t gfp_flags,

		       struct objio_segment **pseg)

{

/*	This is the in memory structure of the objio_segment

fs/nfs/read.c

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ static const struct nfs_pgio_completion_ops nfs_async_read_completion_ops; 


static struct kmem_cache *nfs_rdata_cachep;



struct nfs_read_header *nfs_readhdr_alloc()

struct nfs_read_header *nfs_readhdr_alloc(void)

{

	struct nfs_read_header *rhdr;

CRA Git | Maintained and supported by SUSTech CRA and CCSE