Commit 137e92fd authored Aug 18, 2019 by Wenwen Wang Committed by Richard Weinberger Sep 15, 2019

mtd: sm_ftl: Fix memory leak in sm_init_zone() error path



In sm_init_zone(), 'zone->lba_to_phys_table' is allocated through
kmalloc_array() and 'zone->free_sectors' is allocated in kfifo_alloc()
respectively. However, they are not deallocated in the following execution
if sm_read_sector() fails, leading to memory leaks. To fix this issue, free
them before returning -EIO.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent a3f12a35

drivers/mtd/sm_ftl.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -774,8 +774,11 @@ static int sm_init_zone(struct sm_ftl *ftl, int zone_num)
		continue;

		/* Read the oob of first sector */
		if (sm_read_sector(ftl, zone_num, block, 0, NULL, &oob))
		if (sm_read_sector(ftl, zone_num, block, 0, NULL, &oob)) {
		kfifo_free(&zone->free_sectors);
		kfree(zone->lba_to_phys_table);
		return -EIO;
		}

		/* Test to see if block is erased. It is enough to test
		first sector, because erase happens in one shot */

Admin message