Commit 136b0a47 authored Jan 13, 2017 by Ulf Hansson

mmc: omap: Don't use mmc_card_present() when validating for inserted card

The mmc_card_present() function helps the mmc core to track an internal
state of the card device. More importantly, it's not intended to be used by
mmc host drivers to check for an inserted card. Therefore, let's stop using
it and instead rely on checking for a valid pointer to a struct mmc_card,
as it should be good enough.

Cc: linux-omap@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

parent 009b0fce

drivers/mmc/host/omap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -893,7 +893,7 @@ static void mmc_omap_cover_handler(unsigned long param)
		* If no card is inserted, we postpone polling until
		* the cover has been closed.
		*/
		if (slot->mmc->card == NULL \|\| !mmc_card_present(slot->mmc->card))
		if (slot->mmc->card == NULL)
		return;

		mod_timer(&slot->cover_timer,

Admin message