Commit 135da976 authored Jul 19, 2019 by Qu Wenruo Committed by David Sterba Sep 09, 2019

btrfs: volumes: Add comment for find_free_dev_extent_start()



Since commit 6df9a95e ("Btrfs: make the chunk allocator completely
tree lockless") we search commit root of device tree to avoid deadlock.

This introduced a safety feature, find_free_dev_extent_start() won't
use dev extents which just get freed in current transaction.

This safety feature makes sure we won't allocate new block group using
just freed dev extents to break CoW.

However, this feature also makes find_free_dev_extent_start() not
reliable reporting free device space.  Just add such comment to make
later viewer careful about this behavior.

This behavior makes one caller, btrfs_can_relocate() unreliable
determining the device free space.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 9e3246a5

fs/btrfs/volumes.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1551,6 +1551,12 @@ static bool contains_pending_extent(struct btrfs_device device, u64 start,
		* @len is used to store the size of the free space that we find.
		* But if we don't find suitable free space, it is used to store the size of
		* the max free space.
		*
		* NOTE: This function will search commit root of device tree, and does extra
		* check to ensure dev extents are not double allocated.
		* This makes the function safe to allocate dev extents but may not report
		* correct usable device space, as device extent freed in current transaction
		* is not reported as avaiable.
		*/
		static int find_free_dev_extent_start(struct btrfs_device *device,
		u64 num_bytes, u64 search_start, u64 *start,

Admin message