Commit 1354e72f authored Mar 18, 2019 by Marcelo Ricardo Leitner Committed by David S. Miller Mar 18, 2019

sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DEFAULT_SEND_PARAM sockopt

Currently if the user pass an invalid asoc_id to SCTP_DEFAULT_SEND_PARAM
on a TCP-style socket, it will silently ignore the new parameters.
That's because after not finding an asoc, it is checking asoc_id against
the known values of CURRENT/FUTURE/ALL values and that fails to match.

IOW, if the user supplies an invalid asoc id or not, it should either
match the current asoc or the socket itself so that it will inherit
these later. Fixes it by forcing asoc_id to SCTP_FUTURE_ASSOC in case it
is a TCP-style socket without an asoc, so that the values get set on the
socket.

Fixes: 707e45b3 ("sctp: use SCTP_FUTURE_ASSOC and add SCTP_CURRENT_ASSOC for SCTP_DEFAULT_SEND_PARAM sockopt")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 636d25d5

net/sctp/socket.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -3024,6 +3024,9 @@ static int sctp_setsockopt_default_send_param(struct sock *sk,
		return 0;
		}

		if (sctp_style(sk, TCP))
		info.sinfo_assoc_id = SCTP_FUTURE_ASSOC;

		if (info.sinfo_assoc_id == SCTP_FUTURE_ASSOC \|\|
		info.sinfo_assoc_id == SCTP_ALL_ASSOC) {
		sp->default_stream = info.sinfo_stream;

Admin message